Skip to content

feat(miner-ui): adopt chart and pagination on the portfolio route (#6831) - #6927

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
thomasalvaedison7777-lgtm:feat/miner-ui-portfolio-chart-pagination-6831
Jul 17, 2026
Merged

feat(miner-ui): adopt chart and pagination on the portfolio route (#6831)#6927
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
thomasalvaedison7777-lgtm:feat/miner-ui-portfolio-chart-pagination-6831

Conversation

@thomasalvaedison7777-lgtm

@thomasalvaedison7777-lgtm thomasalvaedison7777-lgtm commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Restyle the miner-ui portfolio route to match the ledgers/run-history ui-kit adoption: content-shaped skeletons, a queue-by-status ChartContainer, and client-side Pagination on the per-repo and queue-actions tables (Miner dashboard: portfolio route skeleton/chart/pagination adoption #6831).
  • Keep StateBoundary async-state primitives; leave portfolio-queue / portfolio-queue-actions fetchers and release/requeue wiring untouched (restyle-only).
  • Add regression coverage for chart render, ≤20 / >20 pagination, sort tie-breakers, and the requeue action path.

Closes #6831

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint — eslint on changed miner-ui files: 0 errors (Prettier-formatted)
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • Miner-ui-only restyle under apps/loopover-miner-ui (outside Codecov src/** patch gate). Ran npm --workspace @loopover/ui-miner run test (full suite green) and scoped eslint/prettier on the three changed files. Broader test:ci / ui:typecheck / ui:build still to run before push.

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

image

Notes

@thomasalvaedison7777-lgtm
feat(miner-ui): enhance portfolio queue with pagination and chart vis…
0fcd144 
…ualization (JSONbored#6831)

- Introduced pagination for the per-repo and queue-actions tables, ensuring they only paginate when exceeding 20 rows.
- Added a horizontal bar chart to visualize queue status counts, improving the UI's data representation.
- Updated tests to cover new pagination behavior and chart rendering, ensuring accurate functionality and user experience.

Closes JSONbored#6831
@superagent-security

superagent-security Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. label Jul 17, 2026
@loopover-orb

loopover-orb Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Tip

✅ LoopOver review result - approve/merge recommended

Review updated: 2026-07-17 13:56:43 UTC

3 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a well-executed restyle-only PR that mirrors the ledgers/run-history ui-kit adoption pattern: adds a ChartContainer bar chart for queue status counts and client-side Pagination to both the repo table and queue-actions table, while explicitly leaving the fetchers and release/requeue wiring untouched. The sort/tie-break logic (total desc then name asc; in_progress-first then repo/identifier) and 20-row pagination boundary are both correct and covered with explicit boundary tests (20 vs 45 rows) and tie-break tests. Issue #6831 is linked and the diff matches its stated scope.

Nits — 5 non-blocking
  • apps/loopover-miner-ui/src/routes/portfolio.tsx: the chart/pagination margin and width literals (4, 12, 88) are unexplained magic numbers — a short comment or named constant would help future editors tune the chart layout.
  • apps/loopover-miner-ui/src/routes/portfolio.tsx ReposTable/QueueActionsTable: the sort + pagination slicing logic is duplicated almost verbatim between the two components; consider extracting a shared `usePaginated(sorted, PAGE_SIZE)` hook.
  • apps/loopover-miner-ui/src/routes/portfolio.tsx TablePagination: page-number links render one PaginationLink per page with no ellipsis/truncation, which could get unwieldy for very large repo/queue counts (not currently exercised by tests).
  • Extract the shared pagination/slice logic from ReposTable and QueueActionsTable into a small hook to avoid the near-duplicate implementations.
  • Consider truncating the page-number list in TablePagination once pageCount grows large, matching common pagination UX patterns.

Decision drivers

  • ✅ Code review — No blockers (1 reviewer)
  • ✅ Gate result — Passing (No configured blocker found.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6831
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 23 registered-repo PR(s), 13 merged, 1 issue(s).
Contributor context ✅ Confirmed Gittensor contributor thomasalvaedison7777-lgtm; Gittensor profile; 23 PR(s), 1 issue(s).
Improvement ✅ Minor risk: clean · value: minor · LLM: moderate
Linked issue satisfaction

Addressed
The diff adds a Skeleton-based content-shaped loading state with a chart-shaped placeholder, a ChartContainer bar chart for queue-by-status counts, and Pagination for both the per-repo and queue-actions tables, while keeping StateBoundary as the shared async-state primitive and leaving portfolio-queue.ts/portfolio-queue-actions.ts and the release/requeue buttons untouched. Regression tests cover t

Review context
  • Author: thomasalvaedison7777-lgtm
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 23 PR(s), 1 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview
Route Viewport Before (production) After (this PR's preview) Diff
/portfolio desktop before /portfolio
before /portfolio		 after /portfolio
after /portfolio		 —
/portfolio mobile before /portfolio (mobile)
before /portfolio (mobile)		 after /portfolio (mobile)
after /portfolio (mobile)		 —

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

loopover-orb[bot]
loopover-orb Bot approved these changes Jul 17, 2026
View reviewed changes

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoopOver approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit 2a80932 into JSONbored:main Jul 17, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loopover-orb loopover-orb[bot] loopover-orb[bot] approved these changes
@JSONbored JSONbored Awaiting requested review from JSONbored JSONbored is a code owner

Assignees

@thomasalvaedison7777-lgtm thomasalvaedison7777-lgtm

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Miner dashboard: portfolio route skeleton/chart/pagination adoption

1 participant

@thomasalvaedison7777-lgtm